Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2524)

Unified Diff: Source/modules/webaudio/AudioSummingJunction.h

Issue 1037683002: Web Audio: Unapply Oilpan to AudioSummingJunction. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove m_didCallDispose Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioParam.cpp ('k') | Source/modules/webaudio/AudioSummingJunction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioSummingJunction.h
diff --git a/Source/modules/webaudio/AudioSummingJunction.h b/Source/modules/webaudio/AudioSummingJunction.h
index 920565ba675a174080251480ac09c0cf776eabfa..f9a34102260c469dee1de7600bf22d2540926c9b 100644
--- a/Source/modules/webaudio/AudioSummingJunction.h
+++ b/Source/modules/webaudio/AudioSummingJunction.h
@@ -32,19 +32,17 @@
namespace blink {
-class AudioContext;
class AudioNodeOutput;
+class DeferredTaskHandler;
// An AudioSummingJunction represents a point where zero, one, or more AudioNodeOutputs connect.
-class AudioSummingJunction : public GarbageCollectedFinalized<AudioSummingJunction> {
+class AudioSummingJunction {
public:
virtual ~AudioSummingJunction();
- DECLARE_VIRTUAL_TRACE();
- void dispose();
// Can be called from any thread.
- AudioContext* context() { return m_context.get(); }
+ DeferredTaskHandler& deferredTaskHandler() { return *m_deferredTaskHandler; }
// This must be called whenever we modify m_outputs.
void changedOutputs();
@@ -61,9 +59,9 @@ public:
virtual void didUpdate() = 0;
protected:
- explicit AudioSummingJunction(AudioContext*);
+ explicit AudioSummingJunction(DeferredTaskHandler&);
- Member<AudioContext> m_context;
+ RefPtr<DeferredTaskHandler> m_deferredTaskHandler;
// m_outputs contains the AudioNodeOutputs representing current connections which are not disabled.
// The rendering code should never use this directly, but instead uses m_renderingOutputs.
@@ -83,8 +81,6 @@ protected:
// m_renderingStateNeedUpdating keeps track if m_outputs is modified.
bool m_renderingStateNeedUpdating;
-
- bool m_didCallDispose;
};
} // namespace blink
« no previous file with comments | « Source/modules/webaudio/AudioParam.cpp ('k') | Source/modules/webaudio/AudioSummingJunction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698