Issue 1037673002: Disentangle Material and InkSplash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1037673002: Disentangle Material and InkSplash (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, ojan

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Disentangle Material and InkSplash Most of the elements that want to be Material (i.e., have a level and cast a shadow) don't want to be InkWells (i.e., have an ink splash effect). This CL disentangles these two components, fixing bugs in the Drawer and in the PopupMenu. Separating these concepts also lets us use Material for the ActionBar and the FloatingActionButton. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/812a152fea6d7de1fdaf6e3007a904bee5bf1d9a

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -35 lines)			Patch
M	sky/framework/components/action_bar.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	sky/framework/components/button.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/framework/components/drawer.dart	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	sky/framework/components/floating_action_button.dart	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	sky/framework/components/material.dart	View	2 chunks	+4 lines, -12 lines	0 comments	Download
M	sky/framework/components/popup_menu.dart	View	3 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

5 years, 9 months ago (2015-03-25 17:43:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
812a152fea6d7de1fdaf6e3007a904bee5bf1d9a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages