sky/framework/components/button.dart - Issue 1037673002: Disentangle Material and InkSplash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/framework/components/button.dart

Issue 1037673002: Disentangle Material and InkSplash (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/framework/components/button.dart

diff --git a/sky/framework/components/button.dart b/sky/framework/components/button.dart

index bcaa0ad4867fea02e6f3590bb37b0559becd2d4b..589253ab3d94cd61d6186ec2ac66ec32a77dc200 100644

--- a/sky/framework/components/button.dart

+++ b/sky/framework/components/button.dart

@@ -26,7 +26,9 @@ class Button extends Component {

Node build() {

return new StyleNode(

- new Material(children: [content], level: level),

+ new Material(

+ content: new InkWell(children: [content]),

+ level: level),

_style);

}

« no previous file with comments | « sky/framework/components/action_bar.dart ('k') | sky/framework/components/drawer.dart » ('j') | no next file with comments »