Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1037573006: Fix accidental updates of host's baselines_ in Elide(). (Closed)

Created:
5 years, 9 months ago by Jun Mukai
Modified:
5 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix accidental updates of host's baselines_ in Elide(). This invocation causes a side effect of setting wrong max to the baselines_ during ElideEmail(), which causes an infinite loop later in ItemizeTextToRuns(). BUG=470179 R=msw@chromium.org TEST=the new test case covers (it doesn't end without this patch) Committed: https://crrev.com/a98db8504afb14ca24e5152f1731c6a49b5e099e Cr-Commit-Position: refs/heads/master@{#322410}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M ui/gfx/render_text.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jun Mukai
5 years, 9 months ago (2015-03-25 23:03:59 UTC) #1
msw
lgtm with nits https://codereview.chromium.org/1037573006/diff/1/ui/gfx/render_text_unittest.cc File ui/gfx/render_text_unittest.cc (right): https://codereview.chromium.org/1037573006/diff/1/ui/gfx/render_text_unittest.cc#newcode722 ui/gfx/render_text_unittest.cc:722: TEST_F(RenderTextTest, HarfBuzz_ElideEmail) { nit: Rename Elide[d]Email, ...
5 years, 9 months ago (2015-03-25 23:17:09 UTC) #2
Jun Mukai
https://codereview.chromium.org/1037573006/diff/1/ui/gfx/render_text_unittest.cc File ui/gfx/render_text_unittest.cc (right): https://codereview.chromium.org/1037573006/diff/1/ui/gfx/render_text_unittest.cc#newcode722 ui/gfx/render_text_unittest.cc:722: TEST_F(RenderTextTest, HarfBuzz_ElideEmail) { On 2015/03/25 23:17:09, msw wrote: > ...
5 years, 9 months ago (2015-03-26 16:34:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037573006/20001
5 years, 9 months ago (2015-03-26 16:35:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 17:27:45 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 17:28:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a98db8504afb14ca24e5152f1731c6a49b5e099e
Cr-Commit-Position: refs/heads/master@{#322410}

Powered by Google App Engine
This is Rietveld 408576698