ui/gfx/render_text_harfbuzz.cc - Issue 1037573006: Fix accidental updates of host's baselines_ in Elide().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 1037573006: Fix accidental updates of host's baselines_ in Elide(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index c931f22216e57951854e33322a597d7271c4ea37..f34dce7e3fb4d8182d76b59b6244dc06c7a036c8 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -1164,6 +1164,9 @@ void RenderTextHarfBuzz::ItemizeTextToRuns(

// Use an empty color BreakList to avoid breaking runs at color boundaries.

BreakList<SkColor> empty_colors;

empty_colors.SetMax(text.length());

+ DCHECK_LE(text.size(), baselines().max());

+ for (const BreakList<bool>& style : styles())

+ DCHECK_LE(text.size(), style.max());

internal::StyleIterator style(empty_colors, baselines(), styles());

for (size_t run_break = 0; run_break < text.length();) {

« no previous file with comments | « ui/gfx/render_text.cc ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »