Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1037573005: SkPDF: add canon assert before adding code that might break it (Closed)

Created:
5 years, 9 months ago by hal.canary
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: add canon assert before adding code that might break it Motivation: We can write subsets (by page) of pdf documents (but this in't yet exposed in the public API), but it is a bad idea to mix pages from multiple documents (de-duping will break). This assert verifies that we don't do this by accident in the future. BUG=skia:3585 Committed: https://skia.googlesource.com/skia/+/26b5d15dab81883fac05a2d3685ca6e3a3459678

Patch Set 1 #

Patch Set 2 : remove TODO message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/pdf/SkPDFDevice.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/pdf/SkPDFDocument.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFDocument.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037573005/1
5 years, 9 months ago (2015-03-25 14:59:39 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-25 14:59:40 UTC) #3
hal.canary
ptal
5 years, 9 months ago (2015-03-25 14:59:42 UTC) #5
mtklein
lgtm
5 years, 9 months ago (2015-03-25 15:14:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037573005/20001
5 years, 9 months ago (2015-03-25 15:14:56 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 15:38:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/26b5d15dab81883fac05a2d3685ca6e3a3459678

Powered by Google App Engine
This is Rietveld 408576698