src/pdf/SkPDFDocument.h - Issue 1037573005: SkPDF: add canon assert before adding code that might break it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDocument.h

Issue 1037573005: SkPDF: add canon assert before adding code that might break it (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: remove TODO message Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFDocument.h

diff --git a/src/pdf/SkPDFDocument.h b/src/pdf/SkPDFDocument.h

index f39b59ef4731e516f00bb4d32e92558968de93ab..b63edc12d2e3dd0bcb2641e683a816e862cac299 100644

--- a/src/pdf/SkPDFDocument.h

+++ b/src/pdf/SkPDFDocument.h

@@ -26,7 +26,6 @@ namespace SkPDFDocument {

* @param pageDevices An array of pages, in order. All pages

* should be created using the same SkPDFCanon.

- * TODO(halcanary): ASSERT this condition.

* @param SkWStream The writable output stream to send the PDF to.

bool EmitPDF(const SkTDArray<SkPDFDevice*>& pageDevices, SkWStream*);

« no previous file with comments | « src/pdf/SkPDFDevice.h ('k') | src/pdf/SkPDFDocument.cpp » ('j') | no next file with comments »