Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1037403004: Land Recent QUIC Changes until 03/27/2015 (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes until 03/27/2015 Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems found by clang_tidy. Merge internal change: 89724433 https://codereview.chromium.org/1047493003/ Fixed header ordering, missing override/explicit keywords. Nothing to see here. Merge internal change: 89622231 https://codereview.chromium.org/1047493002/ Always build a QuicSecureConfigUpdater at startup. Merge internal change: 89604435 https://codereview.chromium.org/1047483002/ Remove the using_pacing argument from QuicSentPacketManager::SetFromConfig because it's always true. Merge internal change: 89599305 https://codereview.chromium.org/1048493002/ Pass QuicCryptoServerConfig by pointer instead of reference. QuicCryptoServerStream was storing const reference to the config, which makes the interface bug-prone because it's not clear for the caller that the config must outlive the stream. Merge internal change: 89542072 https://codereview.chromium.org/1048483002/ Cache the value of GetMaxPlaintextSize in QuicPacketCreator. No functional change. Saves 0.68% in GFE QUIC loadtests. Merge internal change: 89532959 https://codereview.chromium.org/1046523002/ Remove thread race conditions in two tests. No change to production code. Merge internal change: 89510581 https://codereview.chromium.org/1047453003/ Remove QuicFramer::encrypter, because it's a test-only method. Merge internal change: 89499341 https://codereview.chromium.org/1046513002/ Committed: https://crrev.com/1e543ecc66c65c9ba74d7d879fe7822da68f6686 Cr-Commit-Position: refs/heads/master@{#322716}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -261 lines) Patch
M net/quic/congestion_control/pacing_sender.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc View 2 chunks +1 line, -53 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 3 chunks +2 lines, -59 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/quic_connection_test.cc View 14 chunks +20 lines, -20 lines 0 comments Download
M net/quic/quic_framer.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_framer.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_creator.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 4 chunks +20 lines, -11 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 11 chunks +11 lines, -26 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_framer_peer.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_framer_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 3 chunks +6 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-28 18:54:56 UTC) #2
ramant (doing other things)
lgtm
5 years, 8 months ago (2015-03-29 01:41:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1037403004/40001
5 years, 8 months ago (2015-03-29 06:06:44 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-29 07:04:49 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-29 07:05:48 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1e543ecc66c65c9ba74d7d879fe7822da68f6686
Cr-Commit-Position: refs/heads/master@{#322716}

Powered by Google App Engine
This is Rietveld 408576698