net/quic/reliable_quic_stream_test.cc - Issue 1037403004: Land Recent QUIC Changes until 03/27/2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 1037403004: Land Recent QUIC Changes until 03/27/2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/reliable_quic_stream_test.cc

diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc

index f88beb129a31103fa5328fd35777cdd675c6027e..b17def0d1b4fd749cfd1ebda4369df1aafb849b5 100644

--- a/net/quic/reliable_quic_stream_test.cc

+++ b/net/quic/reliable_quic_stream_test.cc

@@ -149,8 +149,7 @@ TEST_F(ReliableQuicStreamTest, WriteAllData) {

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, NOT_IN_FEC_GROUP);

- QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

- length);

+ QuicConnectionPeer::GetPacketCreator(connection_)->SetMaxPacketLength(length);

EXPECT_CALL(*session_, WritevData(kHeadersStreamId, _, _, _, _, _)).WillOnce(

Return(QuicConsumedData(kDataLen, true)));

@@ -209,8 +208,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferData) {

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, NOT_IN_FEC_GROUP);

- QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

- length);

+ QuicConnectionPeer::GetPacketCreator(connection_)->SetMaxPacketLength(length);

EXPECT_CALL(*session_, WritevData(_, _, _, _, _, _)).WillOnce(

Return(QuicConsumedData(kDataLen - 1, false)));

@@ -244,8 +242,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataWithFecProtectAlways) {

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, IN_FEC_GROUP);

- QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

- length);

+ QuicConnectionPeer::GetPacketCreator(connection_)->SetMaxPacketLength(length);

// Write first data onto stream, which will cause one session write.

EXPECT_CALL(*session_, WritevData(_, _, _, _, MUST_FEC_PROTECT, _)).WillOnce(

@@ -280,7 +277,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataWithFecProtectOptional) {

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, NOT_IN_FEC_GROUP);

- QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

+ QuicConnectionPeer::GetPacketCreator(connection_)->SetMaxPacketLength(

length);

// Write first data onto stream, which will cause one session write.

« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »