Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: mojo/services/html_viewer/weburlloader_impl.h

Issue 1037363002: Remove unnecessary 'virtual' annotation from mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolved merge conflicts Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/html_viewer/webthread_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/html_viewer/weburlloader_impl.h
diff --git a/mojo/services/html_viewer/weburlloader_impl.h b/mojo/services/html_viewer/weburlloader_impl.h
index ecfe6c08b35f33fc946506caa20a96a237ac7a6c..abab1ef4fe71a0ab2634df03a7d034815cb62bf9 100644
--- a/mojo/services/html_viewer/weburlloader_impl.h
+++ b/mojo/services/html_viewer/weburlloader_impl.h
@@ -22,7 +22,7 @@ namespace html_viewer {
class WebURLRequestExtraData : public blink::WebURLRequest::ExtraData {
public:
WebURLRequestExtraData();
- virtual ~WebURLRequestExtraData();
+ ~WebURLRequestExtraData() override;
mojo::URLResponsePtr synthetic_response;
};
@@ -35,13 +35,14 @@ class WebURLLoaderImpl : public blink::WebURLLoader {
virtual ~WebURLLoaderImpl();
// blink::WebURLLoader methods:
- virtual void loadSynchronously(
- const blink::WebURLRequest& request, blink::WebURLResponse& response,
- blink::WebURLError& error, blink::WebData& data) override;
- virtual void loadAsynchronously(
- const blink::WebURLRequest&, blink::WebURLLoaderClient* client) override;
- virtual void cancel() override;
- virtual void setDefersLoading(bool defers_loading) override;
+ void loadSynchronously(const blink::WebURLRequest& request,
+ blink::WebURLResponse& response,
+ blink::WebURLError& error,
+ blink::WebData& data) override;
+ void loadAsynchronously(const blink::WebURLRequest&,
+ blink::WebURLLoaderClient* client) override;
+ void cancel() override;
+ void setDefersLoading(bool defers_loading) override;
void OnReceivedResponse(mojo::URLResponsePtr response);
void OnReceivedError(mojo::URLResponsePtr response);
« no previous file with comments | « mojo/services/html_viewer/webthread_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698