Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: mojo/services/html_viewer/webthread_impl.h

Issue 1037363002: Remove unnecessary 'virtual' annotation from mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolved merge conflicts Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/html_viewer/webthemeengine_impl.h ('k') | mojo/services/html_viewer/weburlloader_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/html_viewer/webthread_impl.h
diff --git a/mojo/services/html_viewer/webthread_impl.h b/mojo/services/html_viewer/webthread_impl.h
index 013310dbedba95e77fa18cb89fe588dde58e7d3e..f03d5632ed3b0989dc75e6a2fe8c5c8044e6f9d5 100644
--- a/mojo/services/html_viewer/webthread_impl.h
+++ b/mojo/services/html_viewer/webthread_impl.h
@@ -15,13 +15,12 @@ namespace html_viewer {
class WebThreadBase : public blink::WebThread {
public:
- virtual ~WebThreadBase();
+ ~WebThreadBase() override;
- virtual void addTaskObserver(TaskObserver* observer);
- virtual void removeTaskObserver(TaskObserver* observer);
+ void addTaskObserver(TaskObserver* observer) override;
+ void removeTaskObserver(TaskObserver* observer) override;
- virtual bool isCurrentThread() const = 0;
- virtual blink::PlatformThreadId threadId() const = 0;
+ bool isCurrentThread() const override = 0;
protected:
WebThreadBase();
@@ -36,20 +35,20 @@ class WebThreadBase : public blink::WebThread {
class WebThreadImpl : public WebThreadBase {
public:
explicit WebThreadImpl(const char* name);
- virtual ~WebThreadImpl();
+ ~WebThreadImpl() override;
- virtual void postTask(const blink::WebTraceLocation& location, Task* task);
- virtual void postDelayedTask(const blink::WebTraceLocation& location,
- Task* task,
- long long delay_ms);
+ void postTask(const blink::WebTraceLocation& location, Task* task) override;
+ void postDelayedTask(const blink::WebTraceLocation& location,
+ Task* task,
+ long long delay_ms) override;
- virtual void enterRunLoop();
- virtual void exitRunLoop();
+ void enterRunLoop() override;
+ void exitRunLoop() override;
base::MessageLoop* message_loop() const { return thread_->message_loop(); }
- virtual bool isCurrentThread() const;
- virtual blink::PlatformThreadId threadId() const;
+ bool isCurrentThread() const override;
+ blink::PlatformThreadId threadId() const override;
private:
scoped_ptr<base::Thread> thread_;
@@ -59,19 +58,19 @@ class WebThreadImplForMessageLoop : public WebThreadBase {
public:
explicit WebThreadImplForMessageLoop(
base::MessageLoopProxy* message_loop);
- virtual ~WebThreadImplForMessageLoop();
+ ~WebThreadImplForMessageLoop() override;
- virtual void postTask(const blink::WebTraceLocation& location, Task* task);
- virtual void postDelayedTask(const blink::WebTraceLocation& location,
- Task* task,
- long long delay_ms);
+ void postTask(const blink::WebTraceLocation& location, Task* task) override;
+ void postDelayedTask(const blink::WebTraceLocation& location,
+ Task* task,
+ long long delay_ms) override;
- virtual void enterRunLoop();
- virtual void exitRunLoop();
+ void enterRunLoop() override;
+ void exitRunLoop() override;
private:
- virtual bool isCurrentThread() const;
- virtual blink::PlatformThreadId threadId() const;
+ bool isCurrentThread() const override;
+ blink::PlatformThreadId threadId() const override;
scoped_refptr<base::MessageLoopProxy> message_loop_;
blink::PlatformThreadId thread_id_;
« no previous file with comments | « mojo/services/html_viewer/webthemeengine_impl.h ('k') | mojo/services/html_viewer/weburlloader_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698