Ensure object literal element boilerplates aren't modified.

Ensure object literal element boilerplates aren't modified.

A bug allows JSObject literals with elements to have the elements in the
boilerplate modified.

BUG=466993
LOG=N

Committed: https://crrev.com/7c347c545e33d279b5aa476e754a5358201be846
Cr-Commit-Position: refs/heads/master@{#27511}

[mvstanton, 2015-03-27 14:23:56]

mvstanton@chromium.org changed reviewers:
+ verwaest@chromium.org

[mvstanton, 2015-03-27 14:23:56]

Hi Toon,
This is a pretty simple fix, but I couldn't resist getting rid of redundant code
along the way. Thx for the look,
--Michael

[Toon Verwaest, 2015-03-30 08:42:20]

very nice cleanup, lgtm

https://codereview.chromium.org/1037273002/diff/60001/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/1037273002/diff/60001/src/full-codegen.cc#new...
src/full-codegen.cc:423: expr->has_elements() ||
Add a comment that fast-clone-shallow-object doesn't copy elements, and that
object literals don't support cow elements for now.

[mvstanton, 2015-03-30 08:58:46]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-03-30 08:58:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1037273002/#ps80001
(title: "Added comment and REBASE.")

[commit-bot: I haz the power, 2015-03-30 08:58:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1037273002/80001

[mvstanton, 2015-03-30 08:59:38]

Thx, added comment, checkin' in.

https://codereview.chromium.org/1037273002/diff/60001/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/1037273002/diff/60001/src/full-codegen.cc#new...
src/full-codegen.cc:423: expr->has_elements() ||
On 2015/03/30 08:42:20, Toon Verwaest wrote:
> Add a comment that fast-clone-shallow-object doesn't copy elements, and that
> object literals don't support cow elements for now.

Done.

[commit-bot: I haz the power, 2015-03-30 09:20:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-30 09:20:19]

Patchset 5 (id:??) landed as
https://crrev.com/7c347c545e33d279b5aa476e754a5358201be846
Cr-Commit-Position: refs/heads/master@{#27511}

[Jakob Kummerow, 2015-04-19 10:56:36]

Late DBC: If you explicitly spell out the bug's project as
"BUG=chromium:466993", you'll get a bugdroid comment on the bug when the CL
lands ;-)