gin/wrappable.h - Issue 103703002: Gin: Add support for binding JS methods to C++ instance methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/wrappable.h

Issue 103703002: Gin: Add support for binding JS methods to C++ instance methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase again Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/wrappable.h

diff --git a/gin/wrappable.h b/gin/wrappable.h

index 333a31cedf4a24aa2ccc31b8efdd4f18bcf2dad4..0fa3697863fde2c453e3077c515e89dcc6386471 100644

--- a/gin/wrappable.h

+++ b/gin/wrappable.h

@@ -78,7 +78,7 @@ struct WrappableConverter {

return Converter<Wrappable*>::ToV8(isolate, val);

}

static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val, T** out) {

- Wrappable* wrappable = 0;

+ Wrappable* wrappable = NULL;

if (!Converter<Wrappable*>::FromV8(isolate, val, &wrappable)

|| wrappable->GetWrapperInfo() != &T::kWrapperInfo)

return false;