Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: gin/try_catch.cc

Issue 103703002: Gin: Add support for binding JS methods to C++ instance methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/try_catch.cc
diff --git a/gin/try_catch.cc b/gin/try_catch.cc
index 89a969fa535c8e89df418aa3c588050474a077d4..a44e28e9fe53c90675852e87baf29945e075d11c 100644
--- a/gin/try_catch.cc
+++ b/gin/try_catch.cc
@@ -6,7 +6,6 @@
#include <sstream>
-#include "base/logging.h"
#include "gin/converter.h"
namespace gin {
@@ -22,6 +21,10 @@ bool TryCatch::HasCaught() {
}
std::string TryCatch::GetStackTrace() {
+ if (!HasCaught()) {
+ return "";
+ }
+
std::stringstream ss;
v8::Handle<v8::Message> message = try_catch_.Message();
ss << V8ToString(message->Get()) << std::endl

Powered by Google App Engine
This is Rietveld 408576698