Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1036953002: metrics: Deprecate "perf_data" in UMA proto (Closed)

Created:
5 years, 9 months ago by Simon Que
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

metrics: Deprecate "perf_data" in UMA proto BUG=chromium:470719 TEST=build successfully Signed-off-by: Simon Que <sque@chromium.org>; Committed: https://crrev.com/010be2d621cbca85b99be89f739b4bcebf19b5f1 Cr-Commit-Position: refs/heads/master@{#322483}

Patch Set 1 #

Total comments: 2

Patch Set 2 : deletion -> deprecation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/metrics/proto/chrome_user_metrics_extension.proto View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Simon Que
5 years, 9 months ago (2015-03-25 23:28:01 UTC) #2
Ilya Sherman
https://codereview.chromium.org/1036953002/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto File components/metrics/proto/chrome_user_metrics_extension.proto (left): https://codereview.chromium.org/1036953002/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto#oldcode64 components/metrics/proto/chrome_user_metrics_extension.proto:64: repeated PerfDataProto perf_data = 8; To the best of ...
5 years, 9 months ago (2015-03-26 00:14:06 UTC) #3
Simon Que
https://codereview.chromium.org/1036953002/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto File components/metrics/proto/chrome_user_metrics_extension.proto (left): https://codereview.chromium.org/1036953002/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto#oldcode64 components/metrics/proto/chrome_user_metrics_extension.proto:64: repeated PerfDataProto perf_data = 8; On 2015/03/26 00:14:05, Ilya ...
5 years, 9 months ago (2015-03-26 00:42:09 UTC) #4
Ilya Sherman
LGTM. Please make sure to make the same change on the server side as well.
5 years, 9 months ago (2015-03-26 21:47:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036953002/20001
5 years, 9 months ago (2015-03-26 21:50:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 22:40:08 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 22:40:52 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/010be2d621cbca85b99be89f739b4bcebf19b5f1
Cr-Commit-Position: refs/heads/master@{#322483}

Powered by Google App Engine
This is Rietveld 408576698