Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Side by Side Diff: components/metrics/proto/chrome_user_metrics_extension.proto

Issue 1036953002: metrics: Deprecate "perf_data" in UMA proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Protocol buffer for Chrome UMA (User Metrics Analysis). 5 // Protocol buffer for Chrome UMA (User Metrics Analysis).
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 10
11 package metrics; 11 package metrics;
12 12
13 import "cast_logs.proto"; 13 import "cast_logs.proto";
14 import "histogram_event.proto"; 14 import "histogram_event.proto";
15 import "omnibox_event.proto"; 15 import "omnibox_event.proto";
16 import "profiler_event.proto"; 16 import "profiler_event.proto";
17 import "system_profile.proto"; 17 import "system_profile.proto";
18 import "user_action_event.proto"; 18 import "user_action_event.proto";
19 import "perf_data.proto";
20 import "sampled_profile.proto"; 19 import "sampled_profile.proto";
21 20
22 // Next tag: 13 21 // Next tag: 13
23 message ChromeUserMetricsExtension { 22 message ChromeUserMetricsExtension {
24 // The product (i.e. end user application) for a given UMA log. 23 // The product (i.e. end user application) for a given UMA log.
25 enum Product { 24 enum Product {
26 // Google Chrome product family. 25 // Google Chrome product family.
27 CHROME = 0; 26 CHROME = 0;
28 } 27 }
29 // The product corresponding to this log. The field type is int32 instead of 28 // The product corresponding to this log. The field type is int32 instead of
(...skipping 23 matching lines...) Expand all
53 52
54 // Information about the user's browser and system configuration. 53 // Information about the user's browser and system configuration.
55 optional SystemProfileProto system_profile = 3; 54 optional SystemProfileProto system_profile = 3;
56 55
57 // This message will log one or more of the following event types: 56 // This message will log one or more of the following event types:
58 repeated UserActionEventProto user_action_event = 4; 57 repeated UserActionEventProto user_action_event = 4;
59 repeated OmniboxEventProto omnibox_event = 5; 58 repeated OmniboxEventProto omnibox_event = 5;
60 repeated HistogramEventProto histogram_event = 6; 59 repeated HistogramEventProto histogram_event = 6;
61 repeated ProfilerEventProto profiler_event = 7; 60 repeated ProfilerEventProto profiler_event = 7;
62 61
63 // TODO(sque): Deprecate this field and use |sampled_profile| instead.
64 repeated PerfDataProto perf_data = 8;
Ilya Sherman 2015/03/26 00:14:05 To the best of my knowledge, the best practice is
Simon Que 2015/03/26 00:42:09 Done.
65
66 // A list of all collected sample-based profiles since the last UMA upload. 62 // A list of all collected sample-based profiles since the last UMA upload.
67 repeated SampledProfile sampled_profile = 11; 63 repeated SampledProfile sampled_profile = 11;
68 64
69 // Additional data related with Cast-enabled devices. 65 // Additional data related with Cast-enabled devices.
70 optional CastLogsProto cast_logs = 12; 66 optional CastLogsProto cast_logs = 12;
71 } 67 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698