Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1036863002: Debugger: remove debug command API. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
yurys
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: remove debug command API. Instead, please use v8::Isolate::RequestInterrupt to synchronize to the main thread. R=yurys@chromium.org API=Removed v8::Debug::DebugBreakForCommand LOG=Y Committed: https://crrev.com/8e723e98929b68c87ce39ff9f5c2d136a2ed8a46 Cr-Commit-Position: refs/heads/master@{#27625}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -113 lines) Patch
M include/v8-debug.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/api.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/debug.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/debug.cc View 1 3 chunks +0 lines, -23 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
Please take a look. I plan to land this one week after https://codereview.chromium.org/1038603002/
5 years, 9 months ago (2015-03-25 13:26:09 UTC) #1
yurys
lgtm
5 years, 9 months ago (2015-03-25 13:35:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036863002/1
5 years, 8 months ago (2015-04-07 10:44:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/1505)
5 years, 8 months ago (2015-04-07 10:59:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036863002/20001
5 years, 8 months ago (2015-04-07 11:58:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 12:21:39 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 12:21:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e723e98929b68c87ce39ff9f5c2d136a2ed8a46
Cr-Commit-Position: refs/heads/master@{#27625}

Powered by Google App Engine
This is Rietveld 408576698