Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: src/debug.cc

Issue 1036863002: Debugger: remove debug command API. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 2796d2dc1cbc64a7f2ee527ea47780224ec881ac..c1b301276fc9b00f63f23dfba177cfe0ddc80136 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -34,7 +34,6 @@ Debug::Debug(Isolate* isolate)
message_handler_(NULL),
command_received_(0),
command_queue_(isolate->logger(), kQueueInitialSize),
- event_command_queue_(isolate->logger(), kQueueInitialSize),
is_active_(false),
is_suppressed_(false),
live_edit_enabled_(true), // TODO(yangguo): set to false by default.
@@ -2746,19 +2745,6 @@ void Debug::ProcessDebugEvent(v8::DebugEvent event,
if ((event != v8::Break || !auto_continue) && !event_listener_.is_null()) {
CallEventCallback(event, exec_state, event_data, NULL);
}
- // Process pending debug commands.
- if (event == v8::Break) {
- while (!event_command_queue_.IsEmpty()) {
- CommandMessage command = event_command_queue_.Get();
- if (!event_listener_.is_null()) {
- CallEventCallback(v8::BreakForCommand,
- exec_state,
- event_data,
- command.client_data());
- }
- command.Dispose();
- }
- }
}
@@ -3033,15 +3019,6 @@ void Debug::EnqueueCommandMessage(Vector<const uint16_t> command,
}
-void Debug::EnqueueDebugCommand(v8::Debug::ClientData* client_data) {
- CommandMessage message = CommandMessage::New(Vector<uint16_t>(), client_data);
- event_command_queue_.Put(message);
-
- // Set the debug command break flag to have the command processed.
- if (!in_debug_scope()) isolate_->stack_guard()->RequestDebugCommand();
-}
-
-
MaybeHandle<Object> Debug::Call(Handle<JSFunction> fun, Handle<Object> data) {
DebugScope debug_scope(this);
if (debug_scope.failed()) return isolate_->factory()->undefined_value();
« no previous file with comments | « src/debug.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698