Issue 1036743005: Use correctly-typed error codes for fx_codec_jpx_unittest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1036743005: Use correctly-typed error codes for fx_codec_jpx_unittest (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use correctly-typed error codes for fx_codec_jpx_unittest Needed to fix the failed pdfium_unittests on windows. Ironically, I created these constants so I wouldn't mix up size_t's and off_t's in these tests, but I didn't apply them consistently. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/30506b41ea88cf6743c314743ce477e8186a3945

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp	View		2 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 5 (1 generated)

Tom Sepez

On 2015/03/26 00:42:34, Lei Zhang wrote: > LGTM, but there's a typo in the commit ...

5 years, 9 months ago (2015-03-26 16:36:24 UTC) #4

Tom Sepez

5 years, 9 months ago (2015-03-26 16:36:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
30506b41ea88cf6743c314743ce477e8186a3945 (presubmit successful).