Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp

Issue 1036743005: Use correctly-typed error codes for fx_codec_jpx_unittest (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "codec_int.h" 9 #include "codec_int.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 27 matching lines...) Expand all
38 memset(buffer, 0xbd, sizeof(buffer)); 38 memset(buffer, 0xbd, sizeof(buffer));
39 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd)); 39 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
40 EXPECT_EQ(0xbd, buffer[0]); 40 EXPECT_EQ(0xbd, buffer[0]);
41 41
42 // Reads of nonzero size do nothing but return an error code. 42 // Reads of nonzero size do nothing but return an error code.
43 memset(buffer, 0xbd, sizeof(buffer)); 43 memset(buffer, 0xbd, sizeof(buffer));
44 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd)); 44 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd));
45 EXPECT_EQ(0xbd, buffer[0]); 45 EXPECT_EQ(0xbd, buffer[0]);
46 46
47 // writes of size 0 do nothing but return an error code. 47 // writes of size 0 do nothing but return an error code.
48 EXPECT_EQ(kReadError, opj_write_from_memory(buffer, 0, &dd)); 48 EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, 0, &dd));
49 49
50 // writes of nonzero size do nothing but return an error code. 50 // writes of nonzero size do nothing but return an error code.
51 EXPECT_EQ(kReadError, opj_write_from_memory(buffer, sizeof(buffer), &dd)); 51 EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, sizeof(buffer), &dd));
52 52
53 // Skips of size 0 always return an error code. 53 // Skips of size 0 always return an error code.
54 EXPECT_EQ(kReadError, opj_skip_from_memory(0, &dd)); 54 EXPECT_EQ(kSkipError, opj_skip_from_memory(0, &dd));
55 55
56 // Skips of nonzero size always return an error code. 56 // Skips of nonzero size always return an error code.
57 EXPECT_EQ(kReadError, opj_skip_from_memory(1, &dd)); 57 EXPECT_EQ(kSkipError, opj_skip_from_memory(1, &dd));
58 58
59 // Seeks to 0 offset return in error. 59 // Seeks to 0 offset return in error.
60 EXPECT_FALSE(opj_seek_from_memory(0, &dd)); 60 EXPECT_FALSE(opj_seek_from_memory(0, &dd));
61 61
62 // Seeks to non-zero offsets return in error. 62 // Seeks to non-zero offsets return in error.
63 EXPECT_FALSE(opj_seek_from_memory(1, &dd)); 63 EXPECT_FALSE(opj_seek_from_memory(1, &dd));
64 } 64 }
65 65
66 TEST(fxcodec, DecodeDataZeroSize) { 66 TEST(fxcodec, DecodeDataZeroSize) {
67 DecodeData dd(stream_data, 0); 67 DecodeData dd(stream_data, 0);
68 unsigned char buffer[16]; 68 unsigned char buffer[16];
69 69
70 // Reads of size 0 do nothing but return an error code. 70 // Reads of size 0 do nothing but return an error code.
71 memset(buffer, 0xbd, sizeof(buffer)); 71 memset(buffer, 0xbd, sizeof(buffer));
72 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd)); 72 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
73 EXPECT_EQ(0xbd, buffer[0]); 73 EXPECT_EQ(0xbd, buffer[0]);
74 74
75 // Reads of nonzero size do nothing but return an error code. 75 // Reads of nonzero size do nothing but return an error code.
76 memset(buffer, 0xbd, sizeof(buffer)); 76 memset(buffer, 0xbd, sizeof(buffer));
77 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd)); 77 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd));
78 EXPECT_EQ(0xbd, buffer[0]); 78 EXPECT_EQ(0xbd, buffer[0]);
79 79
80 // writes of size 0 do nothing but return an error code. 80 // writes of size 0 do nothing but return an error code.
81 EXPECT_EQ(kReadError, opj_write_from_memory(buffer, 0, &dd)); 81 EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, 0, &dd));
82 82
83 // writes of nonzero size do nothing but return an error code. 83 // writes of nonzero size do nothing but return an error code.
84 EXPECT_EQ(kReadError, opj_write_from_memory(buffer, sizeof(buffer), &dd)); 84 EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, sizeof(buffer), &dd));
85 85
86 // Skips of size 0 always return an error code. 86 // Skips of size 0 always return an error code.
87 EXPECT_EQ(kReadError, opj_skip_from_memory(0, &dd)); 87 EXPECT_EQ(kSkipError, opj_skip_from_memory(0, &dd));
88 88
89 // Skips of nonzero size always return an error code. 89 // Skips of nonzero size always return an error code.
90 EXPECT_EQ(kReadError, opj_skip_from_memory(1, &dd)); 90 EXPECT_EQ(kSkipError, opj_skip_from_memory(1, &dd));
91 91
92 // Seeks to 0 offset return in error. 92 // Seeks to 0 offset return in error.
93 EXPECT_FALSE(opj_seek_from_memory(0, &dd)); 93 EXPECT_FALSE(opj_seek_from_memory(0, &dd));
94 94
95 // Seeks to non-zero offsets return in error. 95 // Seeks to non-zero offsets return in error.
96 EXPECT_FALSE(opj_seek_from_memory(1, &dd)); 96 EXPECT_FALSE(opj_seek_from_memory(1, &dd));
97 } 97 }
98 98
99 TEST(fxcodec, DecodeDataReadInBounds) { 99 TEST(fxcodec, DecodeDataReadInBounds) {
100 unsigned char buffer[16]; 100 unsigned char buffer[16];
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 EXPECT_EQ(0x84, buffer[0]); 461 EXPECT_EQ(0x84, buffer[0]);
462 EXPECT_EQ(0xbd, buffer[1]); 462 EXPECT_EQ(0xbd, buffer[1]);
463 463
464 // Seeking way beyond EOS is allowed, doesn't wrap, and read fails. 464 // Seeking way beyond EOS is allowed, doesn't wrap, and read fails.
465 memset(buffer, 0xbd, sizeof(buffer)); 465 memset(buffer, 0xbd, sizeof(buffer));
466 EXPECT_TRUE(opj_seek_from_memory( 466 EXPECT_TRUE(opj_seek_from_memory(
467 std::numeric_limits<OPJ_OFF_T>::max(), &dd)); 467 std::numeric_limits<OPJ_OFF_T>::max(), &dd));
468 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd)); 468 EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
469 EXPECT_EQ(0xbd, buffer[0]); 469 EXPECT_EQ(0xbd, buffer[0]);
470 } 470 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698