Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Issue 103673003: Revert of Move popular DOM attributes to prorotype chains (Closed)

Created:
7 years ago by trchen
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/94403002/ Reason for revert: Breaks internal Android instrumentation bots (innerHTML setter crash) TBR=abarth@chromium.org,arv@chromium.org,dcarney@chromium.org,jochen@chromium.org,pfeldman@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -35 lines) Patch
D LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/dom-attribute-on-prototype-chain-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/inspector/console/console-dir-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/NodeList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
trchen
Created Revert of Move popular DOM attributes to prorotype chains
7 years ago (2013-12-04 04:45:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/103673003/1
7 years ago (2013-12-04 04:46:03 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/inspector/console/console-dir-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-04 04:46:11 UTC) #3
trchen
7 years ago (2013-12-04 04:47:47 UTC) #4
Never mind. vollick already done it.

Powered by Google App Engine
This is Rietveld 408576698