Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 103663006: Track *all* external strings in the external string table. (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Track *all* external strings in the external string table. Up till now, external strings may be tracked in the string table (for internalized strings) or the external string table, depending on in which order internalize and externalize happened. The internalized string table should not have to deal with external strings, all of which should be tracked by the external string table. R=svenpanne@chromium.org BUG=326489 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=18285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -56 lines) Patch
M src/api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap.cc View 3 chunks +4 lines, -32 lines 0 comments Download
M src/mark-compact.cc View 4 chunks +18 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years ago (2013-12-09 14:28:06 UTC) #1
Sven Panne
lgtm
7 years ago (2013-12-10 11:31:45 UTC) #2
Yang
7 years ago (2013-12-10 12:11:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18285.

Powered by Google App Engine
This is Rietveld 408576698