Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: src/api.cc

Issue 103663006: Track *all* external strings in the external string table. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 943dbbae56567a93cb82c2d244be68b1990a5bc2..290fcba97aa188a1fe1affb11ca1a4d3e86f62a7 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -5733,8 +5733,8 @@ bool v8::String::MakeExternal(v8::String::ExternalStringResource* resource) {
external = obj;
}
- ASSERT(external->IsExternalString());
- if (result && !external->IsInternalizedString()) {
+ if (result) {
+ ASSERT(external->IsExternalString());
isolate->heap()->external_string_table()->AddString(*external);
}
return result;
@@ -5791,8 +5791,8 @@ bool v8::String::MakeExternal(
external = obj;
}
- ASSERT(external->IsExternalString());
- if (result && !external->IsInternalizedString()) {
+ if (result) {
+ ASSERT(external->IsExternalString());
isolate->heap()->external_string_table()->AddString(*external);
}
return result;
« no previous file with comments | « no previous file | src/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698