Animate showing / hiding the location bar for bookmark apps.

chrome/browser/ui/location_bar/location_bar.h

Index: chrome/browser/ui/location_bar/location_bar.h
diff --git a/chrome/browser/ui/location_bar/location_bar.h b/chrome/browser/ui/location_bar/location_bar.h
index df125323727870e0d7576c58576f11daa665a8cf..23cc047aa7daa531f30c0a21f18fed35e89065c3 100644
--- a/chrome/browser/ui/location_bar/location_bar.h
+++ b/chrome/browser/ui/location_bar/location_bar.h
@@ -61,6 +61,10 @@ class LocationBar {
   // Updates the visibility of the bookmark star.
   virtual void UpdateBookmarkStarVisibility() = 0;
 
+  // Updates the state of the location bar. Animate the transition based if

[Peter Kasting, 2015/04/01 20:27:42]

Nit: Animate -> Animates; remove "based"

[benwells, 2015/04/02 00:36:54]

Done.

+  // |animate| is true.
+  virtual void UpdateLocationBarState(bool visible, bool animate) = 0;

[Peter Kasting, 2015/04/01 20:27:42]

"location bar state" is a pretty vague phrasing when the location bar has a lot
of different types of state.  Could you use "animation state" or "visibility
state" in the comment and function name instead?

[benwells, 2015/04/02 00:36:54]

Done.

+
   // Shows the popup for the given |extension| and, if |grant_active_tab| is
   // true, grants the extension active tab permissions.
   // Returns true if a popup was shown.