Animate showing / hiding the location bar for bookmark apps.

chrome/browser/ui/location_bar/location_bar.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
 #define CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
 
 #include "ui/base/page_transition_types.h"
 #include "ui/base/window_open_disposition.h"
 #include "url/gurl.h"
@@ skipping 43 matching lines @@
 
   // Updates the password icon and pops up a bubble from the icon if needed.
   virtual void UpdateManagePasswordsIconAndBubble() = 0;
 
   // Updates the state of the page actions.
   virtual void UpdatePageActions() = 0;
 
   // Updates the visibility of the bookmark star.
   virtual void UpdateBookmarkStarVisibility() = 0;
 
+  // Updates the state of the location bar. Animate the transition based if

[Peter Kasting, 2015/04/01 20:27:42]

Nit: Animate -> Animates; remove "based"

[benwells, 2015/04/02 00:36:54]

Done.

+  // |animate| is true.
+  virtual void UpdateLocationBarState(bool visible, bool animate) = 0;

[Peter Kasting, 2015/04/01 20:27:42]

"location bar state" is a pretty vague phrasing when the location bar has a lot
of different types of state.  Could you use "animation state" or "visibility
state" in the comment and function name instead?

[benwells, 2015/04/02 00:36:54]

Done.

+
   // Shows the popup for the given |extension| and, if |grant_active_tab| is
   // true, grants the extension active tab permissions.
   // Returns true if a popup was shown.
   virtual bool ShowPageActionPopup(const extensions::Extension* extension,
                                    bool grant_active_tab) = 0;
 
   // Updates the state of the button to open a PDF in Adobe Reader.
   virtual void UpdateOpenPDFInReaderPrompt() = 0;
 
   // Updates the generated credit card view. This view serves as an anchor for
@@ skipping 46 matching lines @@
   virtual void TestPageActionPressed(size_t index) = 0;
 
   // Returns whether or not the bookmark star decoration is visible.
   virtual bool GetBookmarkStarVisibility() = 0;
 
  protected:
   virtual ~LocationBarTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_