Issue 1035963002: IDBRequestTest.AbortErrorAfterAbort: stop request on exit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1035963002: IDBRequestTest.AbortErrorAfterAbort: stop request on exit. (Closed)

Created:
5 years, 9 months ago by sof

Modified:
5 years, 9 months ago

Reviewers:
oilpan-reviews, tkent, haraken

CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford, Jens Widell

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

IDBRequestTest.AbortErrorAfterAbort: stop request on exit. To avoid test instability should a GC happen before a later test calls stopActiveDOMObjects(), have this test stop its request upon exit. Otherwise we risk finalizing the request object while it is in a pending state; something that the IDBRequest destructor checks for. R= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192640

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	Source/modules/indexeddb/IDBRequestTest.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. This failure came up on https://codereview.chromium.org/724833002/ (patchset #3's oilpan_rel trybot runs). ...

5 years, 9 months ago (2015-03-26 15:33:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035963002/1

5 years, 9 months ago (2015-03-26 23:12:53 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-27 00:29:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192640

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages