Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: Source/modules/indexeddb/IDBRequestTest.cpp

Issue 1035963002: IDBRequestTest.AbortErrorAfterAbort: stop request on exit. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBRequestTest.cpp
diff --git a/Source/modules/indexeddb/IDBRequestTest.cpp b/Source/modules/indexeddb/IDBRequestTest.cpp
index ef97d73fdd3839198327888c8194178eb6b6b092..1534acbf69aecc0fca574a0becbcc7ed9e4e62c6 100644
--- a/Source/modules/indexeddb/IDBRequestTest.cpp
+++ b/Source/modules/indexeddb/IDBRequestTest.cpp
@@ -109,6 +109,10 @@ TEST_F(IDBRequestTest, AbortErrorAfterAbort)
// Now simulate the back end having fired an abort error at the request to clear up any intermediaries.
// Ensure an assertion is not raised.
request->onError(DOMError::create(AbortError, "Description goes here."));
+
+ // Stop the request lest it be GCed and its destructor
+ // finds the object in a pending state (and asserts.)
+ executionContext()->stopActiveDOMObjects();
}
class MockWebIDBDatabase : public WebIDBDatabase {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698