Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1035863002: Remove SetDrawViewport (Closed)

Created:
5 years, 9 months ago by ericrk
Modified:
5 years, 9 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SetDrawViewport This change removes SetDrawViewport, instead tracking the current window viewport in DirectRenderer. Committed: https://crrev.com/335d3a8a0e9c22cd0e078865b0b87d2bb348a45e Cr-Commit-Position: refs/heads/master@{#322615}

Patch Set 1 #

Total comments: 2

Patch Set 2 : SetupViewport > SetViewport #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -32 lines) Patch
M cc/output/direct_renderer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/gl_renderer.h View 1 3 chunks +1 line, -2 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 6 chunks +28 lines, -19 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ericrk
5 years, 9 months ago (2015-03-26 00:43:47 UTC) #2
enne (OOO)
https://codereview.chromium.org/1035863002/diff/1/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/1035863002/diff/1/cc/output/gl_renderer.cc#newcode2961 cc/output/gl_renderer.cc:2961: void GLRenderer::SetupViewport() { I would maybe call this SetViewport. ...
5 years, 9 months ago (2015-03-26 20:18:44 UTC) #3
ericrk
https://codereview.chromium.org/1035863002/diff/1/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/1035863002/diff/1/cc/output/gl_renderer.cc#newcode2961 cc/output/gl_renderer.cc:2961: void GLRenderer::SetupViewport() { On 2015/03/26 20:18:44, enne wrote: > ...
5 years, 9 months ago (2015-03-27 00:05:59 UTC) #4
enne (OOO)
lgtm
5 years, 9 months ago (2015-03-27 17:54:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035863002/20001
5 years, 9 months ago (2015-03-27 17:55:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 18:56:43 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 18:57:32 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/335d3a8a0e9c22cd0e078865b0b87d2bb348a45e
Cr-Commit-Position: refs/heads/master@{#322615}

Powered by Google App Engine
This is Rietveld 408576698