Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: Source/bindings/core/v8/ScriptPromisePropertyBase.h

Issue 1035623002: bindings: Use Maybe APIs in ScriptPromise (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptPromisePropertyBase.h
diff --git a/Source/bindings/core/v8/ScriptPromisePropertyBase.h b/Source/bindings/core/v8/ScriptPromisePropertyBase.h
index ecef0b305a96cd4d2c2f077a82af54b585801119..3771e6721cb769cca7223e7d2c4c2ad5730588a6 100644
--- a/Source/bindings/core/v8/ScriptPromisePropertyBase.h
+++ b/Source/bindings/core/v8/ScriptPromisePropertyBase.h
@@ -70,6 +70,8 @@ private:
v8::Handle<v8::String> promiseName();
v8::Handle<v8::String> resolverName();
+ // TODO(bashi): Constructor should take ScriptState and hold it instead of
+ // v8::Isolate*.
haraken 2015/03/25 05:08:29 Yeah, let's fix this in a follow-up. It looks wron
bashi 2015/03/25 07:25:32 Will do.
v8::Isolate* m_isolate;
Name m_name;
State m_state;

Powered by Google App Engine
This is Rietveld 408576698