bindings: Use Maybe APIs in ScriptPromise

Source/bindings/core/v8/ScriptPromisePropertyBase.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScriptPromisePropertyBase_h
 #define ScriptPromisePropertyBase_h
 
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseProperties.h"
@@ skipping 52 matching lines @@
 private:
     typedef Vector<OwnPtr<ScopedPersistent<v8::Object>>> WeakPersistentSet;
 
     void resolveOrRejectInternal(v8::Handle<v8::Promise::Resolver>);
     v8::Local<v8::Object> ensureHolderWrapper(ScriptState*);
     void clearWrappers();
 
     v8::Handle<v8::String> promiseName();
     v8::Handle<v8::String> resolverName();
 
+    // TODO(bashi): Constructor should take ScriptState and hold it instead of
+    // v8::Isolate*.

[haraken, 2015/03/25 05:08:29]

Yeah, let's fix this in a follow-up. It looks wrong to use a current context in
resolveOrRejectInternal. There is no guarantee that the current context is the
context on which the promise wants to be resolved. (The promise needs to be
resolved on the context from which the promise was created.)

[bashi, 2015/03/25 07:25:32]

Will do.

     v8::Isolate* m_isolate;
     Name m_name;
     State m_state;
 
     WeakPersistentSet m_wrappers;
 };
 
 } // namespace blink
 
 #endif // ScriptPromisePropertyBase_h