Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1035553002: message center: Make BoundedLabel override OnPaint instead of Paint. (Closed)

Created:
5 years, 9 months ago by danakj
Modified:
5 years, 9 months ago
Reviewers:
stevenjb, Jun Mukai, dewittj
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org, enne (OOO), piman, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

message center: Make BoundedLabel override OnPaint instead of Paint. This makes the BoundedLabel override View::OnPaint, allowing us to make View::Paint non-virtual. The functional difference is that Paint() calls PaintCommon() which: - Early outs if not visible - Paints any children The BoundedLabel is used by NotificationView, but no children are ever added to it and it's not exposed outside the class. So it's safe to convert it to use OnPaint() and remove the visible early out. R=dewittj@chromium.org, mukai@chromium.org, stevenjb@chromium.org BUG=466426 Committed: https://crrev.com/dfbb1944e145e37b52b6c0665c0c686fdc7ca563 Cr-Commit-Position: refs/heads/master@{#322082}

Patch Set 1 #

Patch Set 2 : boundedlabel: earlyout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M ui/message_center/views/bounded_label.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/bounded_label.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
Hello could one of y'all please have a look?
5 years, 9 months ago (2015-03-24 20:28:22 UTC) #1
Jun Mukai
lgtm
5 years, 9 months ago (2015-03-24 21:50:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035553002/20001
5 years, 9 months ago (2015-03-24 22:05:02 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 22:37:42 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 22:38:38 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfbb1944e145e37b52b6c0665c0c686fdc7ca563
Cr-Commit-Position: refs/heads/master@{#322082}

Powered by Google App Engine
This is Rietveld 408576698