Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: Source/core/paint/SVGClipPainter.h

Issue 1035463002: [S.P.] Use LayoutObject references instead of pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: codereview fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerPainter.cpp ('k') | Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/SVGClipPainter.h
diff --git a/Source/core/paint/SVGClipPainter.h b/Source/core/paint/SVGClipPainter.h
index ae69758dec73425f4415d1674bf11a3bd1abe185..896693497aabce49c0f9c6d2b6fe1a25ad4e800c 100644
--- a/Source/core/paint/SVGClipPainter.h
+++ b/Source/core/paint/SVGClipPainter.h
@@ -28,13 +28,13 @@ public:
// FIXME: Filters are also stateful resources that could benefit from having their state managed
// on the caller stack instead of the current hashmap. We should look at refactoring these
// into a general interface that can be shared.
- bool applyStatefulResource(LayoutObject*, GraphicsContext*, ClipperState&);
- void postApplyStatefulResource(LayoutObject*, GraphicsContext*, ClipperState&);
+ bool applyStatefulResource(const LayoutObject&, GraphicsContext*, ClipperState&);
+ void postApplyStatefulResource(const LayoutObject&, GraphicsContext*, ClipperState&);
// clipPath can be clipped too, but don't have a boundingBox or paintInvalidationRect. So we can't call
// applyResource directly and use the rects from the object, since they are empty for LayoutSVGResources
// FIXME: We made applyClippingToContext public because we cannot call applyResource on HTML elements (it asserts on LayoutObject::objectBoundingBox)
- bool applyClippingToContext(LayoutObject*, const FloatRect&, const FloatRect&, GraphicsContext*, ClipperState&);
+ bool applyClippingToContext(const LayoutObject&, const FloatRect&, const FloatRect&, GraphicsContext*, ClipperState&);
private:
void drawClipMaskContent(GraphicsContext*, DisplayItemClient, const FloatRect&);
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerPainter.cpp ('k') | Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698