Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: Source/core/paint/SVGClipPainter.h

Issue 1035463002: [S.P.] Use LayoutObject references instead of pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: codereview fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerPainter.cpp ('k') | Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SVGClipPainter_h 5 #ifndef SVGClipPainter_h
6 #define SVGClipPainter_h 6 #define SVGClipPainter_h
7 7
8 #include "platform/geometry/FloatRect.h" 8 #include "platform/geometry/FloatRect.h"
9 #include "platform/graphics/paint/DisplayItem.h" 9 #include "platform/graphics/paint/DisplayItem.h"
10 10
(...skipping 10 matching lines...) Expand all
21 ClipperNotApplied, 21 ClipperNotApplied,
22 ClipperAppliedPath, 22 ClipperAppliedPath,
23 ClipperAppliedMask 23 ClipperAppliedMask
24 }; 24 };
25 25
26 SVGClipPainter(LayoutSVGResourceClipper& clip) : m_clip(clip) { } 26 SVGClipPainter(LayoutSVGResourceClipper& clip) : m_clip(clip) { }
27 27
28 // FIXME: Filters are also stateful resources that could benefit from having their state managed 28 // FIXME: Filters are also stateful resources that could benefit from having their state managed
29 // on the caller stack instead of the current hashmap. We should look at refactoring these 29 // on the caller stack instead of the current hashmap. We should look at refactoring these
30 // into a general interface that can be shared. 30 // into a general interface that can be shared.
31 bool applyStatefulResource(LayoutObject*, GraphicsContext*, ClipperState&); 31 bool applyStatefulResource(const LayoutObject&, GraphicsContext*, ClipperSta te&);
32 void postApplyStatefulResource(LayoutObject*, GraphicsContext*, ClipperState &); 32 void postApplyStatefulResource(const LayoutObject&, GraphicsContext*, Clippe rState&);
33 33
34 // clipPath can be clipped too, but don't have a boundingBox or paintInvalid ationRect. So we can't call 34 // clipPath can be clipped too, but don't have a boundingBox or paintInvalid ationRect. So we can't call
35 // applyResource directly and use the rects from the object, since they are empty for LayoutSVGResources 35 // applyResource directly and use the rects from the object, since they are empty for LayoutSVGResources
36 // FIXME: We made applyClippingToContext public because we cannot call apply Resource on HTML elements (it asserts on LayoutObject::objectBoundingBox) 36 // FIXME: We made applyClippingToContext public because we cannot call apply Resource on HTML elements (it asserts on LayoutObject::objectBoundingBox)
37 bool applyClippingToContext(LayoutObject*, const FloatRect&, const FloatRect &, GraphicsContext*, ClipperState&); 37 bool applyClippingToContext(const LayoutObject&, const FloatRect&, const Flo atRect&, GraphicsContext*, ClipperState&);
38 38
39 private: 39 private:
40 void drawClipMaskContent(GraphicsContext*, DisplayItemClient, const FloatRec t&); 40 void drawClipMaskContent(GraphicsContext*, DisplayItemClient, const FloatRec t&);
41 41
42 LayoutSVGResourceClipper& m_clip; 42 LayoutSVGResourceClipper& m_clip;
43 }; 43 };
44 44
45 } // namespace blink 45 } // namespace blink
46 46
47 #endif // SVGClipPainter_h 47 #endif // SVGClipPainter_h
OLDNEW
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayerPainter.cpp ('k') | Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698