[S.P.] Use LayoutObject references instead of pointers.

[S.P.] Use 'const LayoutObject&' in SVGClipPainter.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192461

[Erik Dahlström (inactive), 2015-03-24 13:27:16]

ed@opera.com changed reviewers:
+ fs@opera.com, pdr@chromium.org

[fs, 2015-03-24 14:15:32]

Drop empty BUG=

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/Deprecate...
File Source/core/paint/DeprecatedPaintLayerPainter.cpp (right):

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerPainter.cpp:145:
ASSERT(renderLayer.layoutObject());
This has already been dereferenced above, so this can be dropped.

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerPainter.cpp:158:
ASSERT(m_renderLayer.layoutObject());
As above.

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGClipPa...
File Source/core/paint/SVGClipPainter.h (right):

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGClipPa...
Source/core/paint/SVGClipPainter.h:31: bool applyStatefulResource(LayoutObject&,
GraphicsContext*, ClipperState&);
Feels like this could be const too, but ISTR that conflicting with something -
could you check though?

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGPaintC...
File Source/core/paint/SVGPaintContext.cpp (right):

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGPaintC...
Source/core/paint/SVGPaintContext.cpp:68: ASSERT(m_object);
SVGPaintContext actually gets a reference (which is takes the address of...), so
this should not be needed.

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGPaintC...
Source/core/paint/SVGPaintContext.cpp:132: ASSERT(m_object);
Like above.

[fs, 2015-03-24 14:16:23]

> Use LayoutObject references instead of pointers

...for SVGClipPainter

?

[Erik Dahlström (inactive), 2015-03-24 16:26:00]

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/Deprecate...
File Source/core/paint/DeprecatedPaintLayerPainter.cpp (right):

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerPainter.cpp:145:
ASSERT(renderLayer.layoutObject());
On 2015/03/24 14:15:31, fs wrote:
> This has already been dereferenced above, so this can be dropped.

Done.

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerPainter.cpp:158:
ASSERT(m_renderLayer.layoutObject());
On 2015/03/24 14:15:31, fs wrote:
> As above.

Done.

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGClipPa...
File Source/core/paint/SVGClipPainter.h (right):

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGClipPa...
Source/core/paint/SVGClipPainter.h:31: bool applyStatefulResource(LayoutObject&,
GraphicsContext*, ClipperState&);
On 2015/03/24 14:15:31, fs wrote:
> Feels like this could be const too, but ISTR that conflicting with something -
> could you check though?

Done.

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGPaintC...
File Source/core/paint/SVGPaintContext.cpp (right):

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGPaintC...
Source/core/paint/SVGPaintContext.cpp:68: ASSERT(m_object);
On 2015/03/24 14:15:31, fs wrote:
> SVGPaintContext actually gets a reference (which is takes the address of...),
so
> this should not be needed.

Done.

https://codereview.chromium.org/1035463002/diff/1/Source/core/paint/SVGPaintC...
Source/core/paint/SVGPaintContext.cpp:132: ASSERT(m_object);
On 2015/03/24 14:15:31, fs wrote:
> Like above.

Done.

[fs, 2015-03-24 16:27:54]

The CQ bit was checked by fs@opera.com

[fs, 2015-03-24 16:27:54]

lgtm

[commit-bot: I haz the power, 2015-03-24 16:28:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035463002/20001

[commit-bot: I haz the power, 2015-03-24 19:44:46]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192461