Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 1035283002: only suggest types when completing from a library prefix in parameter list (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
index e8824744485cf14aa2c299aef812384c8c735db0..20cacc77ecbc6c63b556c7e7ba643e5c3dd6d976 100644
--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
@@ -394,8 +394,9 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
with ElementSuggestionBuilder {
final DartCompletionRequest request;
final CompletionSuggestionKind kind;
+ final bool typesOnly;
- LibraryElementSuggestionBuilder(this.request, this.kind);
+ LibraryElementSuggestionBuilder(this.request, this.kind, this.typesOnly);
@override
visitClassElement(ClassElement element) {
@@ -414,7 +415,9 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
@override
visitFunctionElement(FunctionElement element) {
- addSuggestion(element);
+ if (!typesOnly) {
+ addSuggestion(element);
+ }
}
@override
@@ -424,16 +427,18 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
@override
visitTopLevelVariableElement(TopLevelVariableElement element) {
- addSuggestion(element);
+ if (!typesOnly) {
+ addSuggestion(element);
+ }
}
/**
* Add suggestions for the visible members in the given library
*/
static void suggestionsFor(DartCompletionRequest request,
- CompletionSuggestionKind kind, LibraryElement library) {
+ CompletionSuggestionKind kind, LibraryElement library, bool typesOnly) {
if (library != null) {
- library.visitChildren(new LibraryElementSuggestionBuilder(request, kind));
+ library.visitChildren(new LibraryElementSuggestionBuilder(request, kind, typesOnly));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698