pkg/analysis_server/lib/src/services/completion/invocation_computer.dart - Issue 1035283002: only suggest types when completing from a library prefix in parameter list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

Issue 1035283002: only suggest types when completing from a library prefix in parameter list (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/combinator_computer.dart ('k') | pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

index 9d154ec1599539d34a3c8828cfebdb2edd4ed7c8..a2f32a2dee4eca027df845606718723dd6511509 100644

--- a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

@@ -323,8 +323,9 @@ class _PrefixedIdentifierSuggestionBuilder

if (directive.prefix.name == element.name) {

// Suggest elements from the imported library

LibraryElement library = directive.uriElement;

- LibraryElementSuggestionBuilder.suggestionsFor(

- request, CompletionSuggestionKind.INVOCATION, library);

+ LibraryElementSuggestionBuilder.suggestionsFor(request,

+ CompletionSuggestionKind.INVOCATION, library,

+ request.target.containingNode.parent is TypeName);

modified = true;

}