Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1035193002: Adjust file name blacklist in patch.py (Closed)

Created:
5 years, 9 months ago by Paweł Hajdan Jr.
Modified:
5 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Adjust file name blacklist in patch.py - allow the percent sign ('%') - disallow characters from Windows blacklist https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247.aspx#naming_conventions BUG=467152 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M patch.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Paweł Hajdan Jr.
5 years, 9 months ago (2015-03-27 14:22:12 UTC) #2
M-A Ruel
lgtm
5 years, 9 months ago (2015-03-27 14:24:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035193002/1
5 years, 9 months ago (2015-03-27 14:49:03 UTC) #5
commit-bot: I haz the power
Presubmit check for 1035193002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-27 14:52:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035193002/1
5 years, 9 months ago (2015-03-27 15:18:47 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 15:21:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294591

Powered by Google App Engine
This is Rietveld 408576698