patch.py - Issue 1035193002: Adjust file name blacklist in patch.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: patch.py

Issue 1035193002: Adjust file name blacklist in patch.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: patch.py

diff --git a/patch.py b/patch.py

index 9b65ce1cfaed3bc1fbb70551f9cc43346a8f01de..7dcefc011ae81b155604c2e78432e75231cbb4ae 100644

--- a/patch.py

+++ b/patch.py

@@ -50,7 +50,7 @@ class FilePatchBase(object):

def _process_filename(filename):

filename = filename.replace('\\', '/')

# Blacklist a few characters for simplicity.

- for i in ('%', '$', '..', '\'', '"'):

+ for i in ('$', '..', '\'', '"', '<', '>', ':', '|', '?', '*'):

if i in filename:

raise UnsupportedPatchFormat(

filename, 'Can\'t use \'%s\' in filename.' % i)

« no previous file with comments | « no previous file | no next file » | no next file with comments »