Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1035173002: DevTools: Remove old "record frames" instrumentation. (Closed)

Created:
5 years, 9 months ago by eustas
Modified:
5 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove old "record frames" instrumentation. BUG=427418 Committed: https://crrev.com/f0dd3f7e855b028de4b5eac7f09cfbfdd19128b5 Cr-Commit-Position: refs/heads/master@{#322575}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -268 lines) Patch
D content/browser/devtools/protocol/frame_recorder.h View 1 chunk +0 lines, -78 lines 0 comments Download
D content/browser/devtools/protocol/frame_recorder.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 4 chunks +0 lines, -6 lines 1 comment Download
M content/browser/devtools/protocol/page_handler.cc View 6 chunks +2 lines, -17 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eustas
5 years, 9 months ago (2015-03-27 12:37:54 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1035173002/diff/1/content/browser/devtools/protocol/page_handler.h File content/browser/devtools/protocol/page_handler.h (left): https://codereview.chromium.org/1035173002/diff/1/content/browser/devtools/protocol/page_handler.h#oldcode78 content/browser/devtools/protocol/page_handler.h:78: Response CancelRecordingFrames(); Was it never added to protocol.json?
5 years, 9 months ago (2015-03-27 12:58:59 UTC) #3
eustas
On 2015/03/27 12:58:59, dgozman wrote: > lgtm > > https://codereview.chromium.org/1035173002/diff/1/content/browser/devtools/protocol/page_handler.h > File content/browser/devtools/protocol/page_handler.h (left): > ...
5 years, 9 months ago (2015-03-27 13:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035173002/1
5 years, 9 months ago (2015-03-27 13:06:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 14:21:53 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 14:22:33 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f0dd3f7e855b028de4b5eac7f09cfbfdd19128b5
Cr-Commit-Position: refs/heads/master@{#322575}

Powered by Google App Engine
This is Rietveld 408576698