Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 1035173002: DevTools: Remove old "record frames" instrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.cc
diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc
index 15dee24abee8a1aa50cca995f7053154ce604853..827473b2dd800776025c8a303d48f69b8d604a4a 100644
--- a/content/browser/devtools/protocol/page_handler.cc
+++ b/content/browser/devtools/protocol/page_handler.cc
@@ -12,7 +12,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/threading/worker_pool.h"
#include "content/browser/devtools/protocol/color_picker.h"
-#include "content/browser/devtools/protocol/frame_recorder.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/browser/web_contents/web_contents_impl.h"
@@ -99,7 +98,6 @@ PageHandler::PageHandler()
processing_screencast_frame_(false),
color_picker_(new ColorPicker(base::Bind(
&PageHandler::OnColorPicked, base::Unretained(this)))),
- frame_recorder_(new FrameRecorder()),
host_(nullptr),
screencast_listener_(nullptr),
weak_factory_(this) {
@@ -113,7 +111,6 @@ void PageHandler::SetRenderViewHost(RenderViewHostImpl* host) {
return;
color_picker_->SetRenderViewHost(host);
- frame_recorder_->SetRenderViewHost(host);
host_ = host;
}
@@ -135,7 +132,6 @@ void PageHandler::OnSwapCompositorFrame(
if (screencast_enabled_)
InnerSwapCompositorFrame();
color_picker_->OnSwapCompositorFrame();
- frame_recorder_->OnSwapCompositorFrame();
}
void PageHandler::OnVisibilityChanged(bool visible) {
@@ -305,16 +301,11 @@ Response PageHandler::StopScreencast() {
}
Response PageHandler::StartRecordingFrames(int max_frame_count) {
- return frame_recorder_->StartRecordingFrames(max_frame_count);
+ return Response::OK();
}
Response PageHandler::StopRecordingFrames(DevToolsCommandId command_id) {
- return frame_recorder_->StopRecordingFrames(base::Bind(
- &PageHandler::OnFramesRecorded, base::Unretained(this), command_id));
-}
-
-Response PageHandler::CancelRecordingFrames() {
- return frame_recorder_->CancelRecordingFrames();
+ return Response::OK();
}
Response PageHandler::ScreencastFrameAck(int frame_number) {
@@ -498,12 +489,6 @@ void PageHandler::OnColorPicked(int r, int g, int b, int a) {
client_->ColorPicked(ColorPickedParams::Create()->set_color(color));
}
-void PageHandler::OnFramesRecorded(
- DevToolsCommandId command_id,
- scoped_refptr<StopRecordingFramesResponse> response_data) {
- client_->SendStopRecordingFramesResponse(command_id, response_data);
-}
-
} // namespace page
} // namespace devtools
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698