Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1034803002: Fixed the sizing bug for PDFs opened from links with target=_blank. (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed the sizing bug for PDFs opened from links with target=_blank. BUG=462677, 469652 Committed: https://crrev.com/78ed69f066f58c82923a0cd34f1d5a3ab98c5d53 Cr-Commit-Position: refs/heads/master@{#322277}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Patch Set 3 : Took out unrelated files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M extensions/browser/guest_view/guest_view_base.cc View 1 2 chunks +28 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-25 19:20:14 UTC) #2
Fady Samuel
Does this work with a PDF in a <webview>? https://codereview.chromium.org/1034803002/diff/1/extensions/browser/guest_view/guest_view_base.cc File extensions/browser/guest_view/guest_view_base.cc (right): https://codereview.chromium.org/1034803002/diff/1/extensions/browser/guest_view/guest_view_base.cc#newcode791 extensions/browser/guest_view/guest_view_base.cc:791: ...
5 years, 9 months ago (2015-03-25 20:30:10 UTC) #3
paulmeyer
I tried it out and it appears to work fine in webview as well. https://codereview.chromium.org/1034803002/diff/1/extensions/browser/guest_view/guest_view_base.cc ...
5 years, 9 months ago (2015-03-25 20:58:36 UTC) #4
Fady Samuel
Cool! lgtm
5 years, 9 months ago (2015-03-25 21:23:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034803002/20001
5 years, 9 months ago (2015-03-25 21:24:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51913)
5 years, 9 months ago (2015-03-25 21:34:12 UTC) #9
paulmeyer
On 2015/03/25 21:34:12, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-25 23:18:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034803002/40001
5 years, 9 months ago (2015-03-25 23:19:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-26 00:39:08 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:39:44 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78ed69f066f58c82923a0cd34f1d5a3ab98c5d53
Cr-Commit-Position: refs/heads/master@{#322277}

Powered by Google App Engine
This is Rietveld 408576698