Fixed the sizing bug for PDFs opened from links with target=_blank.

extensions/browser/guest_view/guest_view_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/guest_view_base.h"
 
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/ui/zoom/page_zoom.h"
 #include "components/ui/zoom/zoom_controller.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/page_zoom.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/browser/api/extensions_api_client.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/guest_view/app_view/app_view_guest.h"
 #include "extensions/browser/guest_view/extension_options/extension_options_guest.h"
 #include "extensions/browser/guest_view/extension_view/extension_view_guest.h"
 #include "extensions/browser/guest_view/guest_view_manager.h"
@@ skipping 750 matching lines @@
   int max_height = 0;
   int max_width = 0;
   params.GetInteger(guestview::kAttributeMaxHeight, &max_height);
   params.GetInteger(guestview::kAttributeMaxWidth, &max_width);
 
   int min_height = 0;
   int min_width = 0;
   params.GetInteger(guestview::kAttributeMinHeight, &min_height);
   params.GetInteger(guestview::kAttributeMinWidth, &min_width);
 
-  // Set the normal size to the element size so that the guestview will fit the
-  // element initially if autosize is disabled.
-  double element_height = 0.0;
-  double element_width = 0.0;
-  params.GetDouble(guestview::kElementHeight, &element_height);
-  params.GetDouble(guestview::kElementWidth, &element_width);
-
-  // If the element size was provided in logical units (versus physical), then
-  // it will be converted to physical units.
-  bool element_size_is_logical = false;
-  params.GetBoolean(guestview::kElementSizeIsLogical, &element_size_is_logical);
   int normal_height = 0;
   int normal_width = 0;
-  if (element_size_is_logical) {
-    // Convert the element size from logical pixels to physical pixels.
-    normal_height = LogicalPixelsToPhysicalPixels(element_height);
-    normal_width = LogicalPixelsToPhysicalPixels(element_width);
+  if (is_full_page_plugin()) {
+    // The initial size of a full page plugin should be set to fill the
+    // embedder's visible viewport.
+    auto embedder_size = embedder_web_contents()->GetRenderWidgetHostView()->

[Fady Samuel, 2015/03/25 20:30:10]

Use owner_web_contents() instead. embedder_web_contents() is not available until
attachment.

[paulmeyer, 2015/03/25 20:58:36]

Done.

+        GetVisibleViewportSize();
+    normal_height = embedder_size.height();
+    normal_width = embedder_size.width();
   } else {
-    normal_height = lround(element_height);
-    normal_width = lround(element_width);
+    // Set the normal size to the element size so that the guestview will fit
+    // the element initially if autosize is disabled.
+    double element_height = 0.0;
+    double element_width = 0.0;
+    params.GetDouble(guestview::kElementHeight, &element_height);
+    params.GetDouble(guestview::kElementWidth, &element_width);
+
+    // If the element size was provided in logical units (versus physical), then
+    // it will be converted to physical units.
+    bool element_size_is_logical = false;
+    params.GetBoolean(guestview::kElementSizeIsLogical,
+                      &element_size_is_logical);
+    if (element_size_is_logical) {
+      // Convert the element size from logical pixels to physical pixels.
+      normal_height = LogicalPixelsToPhysicalPixels(element_height);
+      normal_width = LogicalPixelsToPhysicalPixels(element_width);
+    } else {
+      normal_height = lround(element_height);
+      normal_width = lround(element_width);
+    }
   }
 
   SetSizeParams set_size_params;
   set_size_params.enable_auto_size.reset(new bool(auto_size_enabled));
   set_size_params.min_size.reset(new gfx::Size(min_width, min_height));
   set_size_params.max_size.reset(new gfx::Size(max_width, max_height));
   set_size_params.normal_size.reset(new gfx::Size(normal_width, normal_height));
 
   // Call SetSize to apply all the appropriate validation and clipping of
   // values.
@@ skipping 32 matching lines @@
 void GuestViewBase::RegisterGuestViewTypes() {
   AppViewGuest::Register();
   ExtensionOptionsGuest::Register();
   ExtensionViewGuest::Register();
   MimeHandlerViewGuest::Register();
   SurfaceWorkerGuest::Register();
   WebViewGuest::Register();
 }
 
 }  // namespace extensions