Source/modules/webdatabase/SQLTransactionBackendSync.h - Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/SQLTransactionBackendSync.h

Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix RefPtr/OwnPtr transition gcc errors Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webdatabase/SQLTransactionBackendSync.h

diff --git a/Source/modules/webdatabase/SQLTransactionBackendSync.h b/Source/modules/webdatabase/SQLTransactionBackendSync.h

index 1196571ab80e5fb8e65d44f2f235376f1c436ea8..43b1d7872803d524649dbe15e4f32ed0db302803 100644

--- a/Source/modules/webdatabase/SQLTransactionBackendSync.h

+++ b/Source/modules/webdatabase/SQLTransactionBackendSync.h

@@ -64,10 +64,10 @@ public:

void rollback();

private:

- SQLTransactionBackendSync(DatabaseSync*, PassRefPtr<SQLTransactionSyncCallback>, bool readOnly);

+ SQLTransactionBackendSync(DatabaseSync*, PassOwnPtr<SQLTransactionSyncCallback>, bool readOnly);

RefPtr<DatabaseSync> m_database;

- RefPtr<SQLTransactionSyncCallback> m_callback;

+ OwnPtr<SQLTransactionSyncCallback> m_callback;

bool m_readOnly;

bool m_hasVersionMismatch;