Source/modules/webdatabase/SQLTransactionBackendSync.h - Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/webdatabase/SQLTransactionBackendSync.h

Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix RefPtr/OwnPtr transition gcc errors Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/modules/webdatabase/SQLTransaction.cpp ('k') | Source/modules/webdatabase/SQLTransactionBackendSync.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 * Copyright (C) 2013 Apple Inc. All rights reserved.	3 * Copyright (C) 2013 Apple Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57	57

58 DatabaseSync* database() { return m_database.get(); }	58 DatabaseSync* database() { return m_database.get(); }

59 bool isReadOnly() const { return m_readOnly; }	59 bool isReadOnly() const { return m_readOnly; }

60	60

61 void begin(ExceptionState&);	61 void begin(ExceptionState&);

62 void execute(ExceptionState&);	62 void execute(ExceptionState&);

63 void commit(ExceptionState&);	63 void commit(ExceptionState&);

64 void rollback();	64 void rollback();

65	65

66 private:	66 private:

67 SQLTransactionBackendSync(DatabaseSync*, PassRefPtr<SQLTransactionSyncCallba ck>, bool readOnly);	67 SQLTransactionBackendSync(DatabaseSync*, PassOwnPtr<SQLTransactionSyncCallba ck>, bool readOnly);

68	68

69 RefPtr<DatabaseSync> m_database;	69 RefPtr<DatabaseSync> m_database;

70 RefPtr<SQLTransactionSyncCallback> m_callback;	70 OwnPtr<SQLTransactionSyncCallback> m_callback;

71 bool m_readOnly;	71 bool m_readOnly;

72 bool m_hasVersionMismatch;	72 bool m_hasVersionMismatch;

73	73

74 bool m_modifiedDatabase;	74 bool m_modifiedDatabase;

75 OwnPtr<SQLTransactionClient> m_transactionClient;	75 OwnPtr<SQLTransactionClient> m_transactionClient;

76 OwnPtr<SQLiteTransaction> m_sqliteTransaction;	76 OwnPtr<SQLiteTransaction> m_sqliteTransaction;

77	77

78 friend class SQLTransactionSync; // FIXME: Remove this once the front-end ha s been properly isolated.	78 friend class SQLTransactionSync; // FIXME: Remove this once the front-end ha s been properly isolated.

79 };	79 };

80	80

81 } // namespace WebCore	81 } // namespace WebCore

82	82

83 #endif // SQLTransactionBackendSync_h	83 #endif // SQLTransactionBackendSync_h

OLD	NEW