Source/modules/webdatabase/Database.h - Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/Database.h

Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorDatabaseAgent.cpp ('K') | « Source/modules/webdatabase/DOMWindowWebDatabase.cpp ('k') | Source/modules/webdatabase/Database.cpp » ('j') | Source/modules/webdatabase/Database.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/Database.h

diff --git a/Source/modules/webdatabase/Database.h b/Source/modules/webdatabase/Database.h

index d17bb20d9b53a0102fe125dcc3bab31577f9d52d..0db19c3a8b7e4772fe1705ba1dc6063a75836aa5 100644

--- a/Source/modules/webdatabase/Database.h

+++ b/Source/modules/webdatabase/Database.h

@@ -54,9 +54,9 @@ public:

// Direct support for the DOM API

virtual String version() const;

- void changeVersion(const String& oldVersion, const String& newVersion, PassRefPtr<SQLTransactionCallback>, PassRefPtr<SQLTransactionErrorCallback>, PassRefPtr<SQLVoidCallback> successCallback);

- void transaction(PassRefPtr<SQLTransactionCallback>, PassRefPtr<SQLTransactionErrorCallback>, PassRefPtr<SQLVoidCallback> successCallback);

- void readTransaction(PassRefPtr<SQLTransactionCallback>, PassRefPtr<SQLTransactionErrorCallback>, PassRefPtr<SQLVoidCallback> successCallback);

+ void changeVersion(const String& oldVersion, const String& newVersion, PassOwnPtr<SQLTransactionCallback>, PassOwnPtr<SQLTransactionErrorCallback>, PassOwnPtr<SQLVoidCallback> successCallback);

+ void transaction(PassOwnPtr<SQLTransactionCallback>, PassOwnPtr<SQLTransactionErrorCallback>, PassOwnPtr<SQLVoidCallback> successCallback);

+ void readTransaction(PassOwnPtr<SQLTransactionCallback>, PassOwnPtr<SQLTransactionErrorCallback>, PassOwnPtr<SQLVoidCallback> successCallback);

// Internal engine support

static Database* from(DatabaseBackend*);

@@ -76,8 +76,8 @@ private:

PassRefPtr<DatabaseBackend> backend();

static PassRefPtr<Database> create(ExecutionContext*, PassRefPtr<DatabaseBackendBase>);

- void runTransaction(PassRefPtr<SQLTransactionCallback>, PassRefPtr<SQLTransactionErrorCallback>,

- PassRefPtr<SQLVoidCallback> successCallback, bool readOnly, const ChangeVersionData* = 0);

+ void runTransaction(PassOwnPtr<SQLTransactionCallback>, PassOwnPtr<SQLTransactionErrorCallback>,

+ PassOwnPtr<SQLVoidCallback> successCallback, bool readOnly, const ChangeVersionData* = 0);

Vector<String> performGetTableNames();