Source/modules/webdatabase/DOMWindowWebDatabase.cpp - Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/DOMWindowWebDatabase.cpp

Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorDatabaseAgent.cpp ('K') | « Source/modules/webdatabase/DOMWindowWebDatabase.h ('k') | Source/modules/webdatabase/Database.h » ('j') | Source/modules/webdatabase/Database.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/DOMWindowWebDatabase.cpp

diff --git a/Source/modules/webdatabase/DOMWindowWebDatabase.cpp b/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

index df93f7c834971d23ea7b68affdf132fc28bfe49d..ed2df590b9e020d19b3541d7897cdbe2b8722356 100644

--- a/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

+++ b/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

@@ -41,7 +41,7 @@

namespace WebCore {

-PassRefPtr<Database> DOMWindowWebDatabase::openDatabase(DOMWindow* window, const String& name, const String& version, const String& displayName, unsigned long estimatedSize, PassRefPtr<DatabaseCallback> creationCallback, ExceptionState& exceptionState)

+PassRefPtr<Database> DOMWindowWebDatabase::openDatabase(DOMWindow* window, const String& name, const String& version, const String& displayName, unsigned long estimatedSize, PassOwnPtr<DatabaseCallback> creationCallback, ExceptionState& exceptionState)

{

if (!window->isCurrentlyDisplayedInFrame())

return 0;