Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1034713004: Refactors gesture conversion functions to ui/events/blink (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 8 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, jdduke+watch_chromium.org, kalyank, nona+watch_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, James Su, tdresser+watch_chromium.org, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactors gesture conversion functions to ui/events/blink We want to use this from html_viewer, which can't depend on content. BUG=none TEST=none R=jam@chromium.org, sadrul@chromium.org, dglazkov@chromium.org Committed: https://crrev.com/83e08f5e90e017aa7dd9daa60cce84a242e631c8 Cr-Commit-Position: refs/heads/master@{#322582}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : Fix gyp #

Patch Set 4 : fix M_PI usage for windows #

Total comments: 1

Patch Set 5 : unsigned #

Patch Set 6 : merge 2 trunk #

Patch Set 7 : specific dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -542 lines) Patch
M content/browser/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 3 chunks +1 line, -276 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A ui/events/blink/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A + ui/events/blink/DEPS View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
A ui/events/blink/blink_event_util.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + ui/events/blink/blink_event_util.cc View 1 2 3 4 6 chunks +66 lines, -229 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
sky
5 years, 9 months ago (2015-03-25 21:33:54 UTC) #1
sky
john: content/ sadrul: making sure you're ok with this in ui/events/blink jochen: DEPS include of ...
5 years, 9 months ago (2015-03-25 21:34:40 UTC) #2
sky
Naming and where to put stuff is always tricky. I could see at least two ...
5 years, 9 months ago (2015-03-25 22:14:55 UTC) #3
sadrul
I prefer option 1 too. lgtm https://codereview.chromium.org/1034713004/diff/50019/ui/events/blink/DEPS File ui/events/blink/DEPS (right): https://codereview.chromium.org/1034713004/diff/50019/ui/events/blink/DEPS#newcode2 ui/events/blink/DEPS:2: "+third_party/WebKit/public/platform", We probably ...
5 years, 9 months ago (2015-03-25 22:19:33 UTC) #4
jochen (gone - plz use gerrit)
ui/events might end up in browser, right? In that case, we can't blanket allow all ...
5 years, 9 months ago (2015-03-26 15:36:52 UTC) #5
jam
lgtm
5 years, 9 months ago (2015-03-26 15:43:40 UTC) #6
sky
On 2015/03/26 15:36:52, jochen wrote: > ui/events might end up in browser, right? > > ...
5 years, 9 months ago (2015-03-26 17:07:35 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-27 14:43:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034713004/100001
5 years, 9 months ago (2015-03-27 15:39:13 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:100001)
5 years, 9 months ago (2015-03-27 15:42:56 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 15:43:32 UTC) #13
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/83e08f5e90e017aa7dd9daa60cce84a242e631c8
Cr-Commit-Position: refs/heads/master@{#322582}

Powered by Google App Engine
This is Rietveld 408576698