Issue 1034573002: Improve QUIC tests. Correct things clang_tidy complains about.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1034573002: Improve QUIC tests. Correct things clang_tidy complains about. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton

Modified:
5 years, 9 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Improve QUIC tests. Correct things clang_tidy complains about. Make QuicTimeWaitListManager::AddConnectionIdToTimeWait virtual so it can be mocked. Correct things clang_tidy complains about. Make a method virtual so it can be mocked. Merge internal change: 88744988 R=rtenneti@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -41 lines)			Patch
M	net/tools/quic/quic_dispatcher_test.cc	View	5 chunks	+6 lines, -17 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager.h	View	3 chunks	+14 lines, -11 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager_test.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages