Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: net/tools/quic/test_tools/quic_test_utils.cc

Issue 1034573002: Improve QUIC tests. Correct things clang_tidy complains about. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/test_tools/quic_test_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/test_tools/quic_test_utils.cc
diff --git a/net/tools/quic/test_tools/quic_test_utils.cc b/net/tools/quic/test_tools/quic_test_utils.cc
index 6a5e93c8e593a2237ede843a94e270a5d6403f13..0aa96ff52f8eb269ab936afaa5d3ecb242294f9b 100644
--- a/net/tools/quic/test_tools/quic_test_utils.cc
+++ b/net/tools/quic/test_tools/quic_test_utils.cc
@@ -19,6 +19,10 @@ namespace net {
namespace tools {
namespace test {
+using testing::_;
+using testing::AnyNumber;
+using testing::Invoke;
+
QuicAckFrame MakeAckFrameWithNackRanges(
size_t num_nack_ranges, QuicPacketSequenceNumber least_unacked) {
QuicAckFrame ack = MakeAckFrame(2 * num_nack_ranges + least_unacked);
@@ -117,6 +121,14 @@ MockTimeWaitListManager::MockTimeWaitListManager(
QuicServerSessionVisitor* visitor,
EpollServer* eps)
: QuicTimeWaitListManager(writer, visitor, eps, QuicSupportedVersions()) {
+ // Though AddConnectionIdToTimeWait is mocked, we want to retain its
+ // functionality.
+ EXPECT_CALL(*this, AddConnectionIdToTimeWait(_, _, _))
+ .Times(AnyNumber());
+ ON_CALL(*this, AddConnectionIdToTimeWait(_, _, _))
+ .WillByDefault(Invoke(this,
+ &MockTimeWaitListManager::
+ QuicTimeWaitListManager_AddConnectionIdToTimeWait));
}
MockTimeWaitListManager::~MockTimeWaitListManager() {
« no previous file with comments | « net/tools/quic/test_tools/quic_test_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698