Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1034523003: Fine tune const NSClass* presubmit check (Closed)

Created:
5 years, 9 months ago by Dominik Röttsches
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Fine tune const NSClass* presubmit check Blink CL https://codereview.chromium.org/879533003/ defines own casts to convert between bridged types. The cast helpers in base cannot be used in Blink. Fine tune the presubmit check to allow for those by adding a negative look behind for reinterpret_cast. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294560

Patch Set 1 #

Patch Set 2 : Split regex line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M presubmit_canned_checks.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Dominik Röttsches
PTAL
5 years, 9 months ago (2015-03-24 19:42:50 UTC) #2
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-25 01:26:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034523003/1
5 years, 9 months ago (2015-03-25 06:21:16 UTC) #7
commit-bot: I haz the power
Presubmit check for 1034523003-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-25 06:24:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034523003/20001
5 years, 9 months ago (2015-03-25 07:32:54 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 07:36:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294560

Powered by Google App Engine
This is Rietveld 408576698